Skip to content

Carets - Guillermina#31

Open
murog wants to merge 46 commits intoAda-C8:masterfrom
murog:master
Open

Carets - Guillermina#31
murog wants to merge 46 commits intoAda-C8:masterfrom
murog:master

Conversation

@murog
Copy link

@murog murog commented Nov 6, 2017 •
edited
Loading

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I read through the documentation and found an example on how to conduct a query using the word "chicken." I played with the parameters on the link to figure out how to get what I needed out of the API.
Describe your API Wrapper. How did you decide on the methods you created? My API Wrapper only has two methods. Reviewing them, I could have created some helper methods to DRY up the code since they are kind of long. The first one "self.list_recipes" takes in a params hash and pulls information it needs out of it to make a request. If a "from" and "to" range is not include, it makes the query starting a 0 and ending at 10. It also updates the url if a health label is given in the params. If the query is successful, it returns an array of recipe objects. If the query is unsuccessful, it returns an empty array. The second method, "self.find_recipe", takes in a recipe uri (as a string) and makes a request based on the uri. If it is successful, it will return a recipe object. If it is not, it returns false.
Describe an edge case or failure case test you wrote for your API Wrapper. An edge I tested for was that it would be able to successfully make a request on a multi word query that includes blank spaces. It was successful, which surprised me!
Explain how VCR aids in testing an API. VCR saves requests you make on an API. When you make a duplicate requests, it will compare your test again the saved response from the past. This is helpful because it minimizes the amount of calls you make on an API and reduces the chances of you getting timed out or banned from using their service.
What is the Heroku URL of your deployed application? http://gm-muncher.herokuapp.com/

murog added 30 commits November 1, 2017 10:00
@murog
made new rails app, confirmed gemfile
757d7da
@murog
updated gitignore, token and gemfile.
8903231
@murog
fixed typo, updated application.rb to load lib:
dc6136a
@murog
configured test helper to include vcr, added test for api wrapper
1ee1830
@murog
renamed api wrapper test
ae0e345
@murog
began testing file
f9a3c00
@murog
updated list recipe method, passing tests for find group of recipes w…
d24717e 
…ith health labels and single/multi word search queries
@murog
passing tests for recipe and api wrapper making instances of recipe
beaefc1
@murog
uncommented out broken request test
2197845
@murog
updated api wrapper to return a hash, one test failing but thinking i…
b809a14 
…t is due to being timed out by app?? will try later
@murog
added foundation-rails gem, root to application#index
e6787da
@murog
passing tests for populating search page with recipes
efcf8e2
@murog
pages are working through sent params
1b8c44e
@murog
working page links
7e05a09
@murog
updated cassettes
2f0dce5
@murog
added config lines to fix heroku issue
c95e035
@murog
added render 404 to show action in recipes controller
5eddcd1
@murog
added show_recipe_path to routes
6bd4c59
@murog
added uri to recipe class, added find_recipe to api wrapper
d9b6668
@murog
passing tests for api call on finding a recipes and returning a recip…
e87cd65 
…e object, controller populate show page with relevant recipe info
@murog
updated show page to include recipe details in a table
660ac3c
@murog
added omniauth for google
0668ae3
@murog
created user model and sessions controller
0d1af41
@murog
passing user tests, creates user fixtures, updated user model to incl…
ed32a42 
…ude provider, can log in using google_login_path
@murog
added tests for testing logging in with google, one is currently failing
42e4883
@murog
passing tests for logout, added logout to routes and link to layout
51dd508
@murog
users have favorites, can view favorites on fav page
318cc8d
@murog
fixed numbered lists, added favorites link for when a user is logged in
4535788
@murog
passing tests for recent_searches attribute for user
6e66421
@murog
updated controller to only use pages action
1569524
@CheezItMan
Copy link

CheezItMan commented Nov 7, 2017

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check
General
Rails fundamentals (RESTful routing, use of named paths) Check
Semantic HTML Check
Errors are reported to the user No error reported
API Wrapper to handle the API requests Check
Controller testing Check
Lib testing Check
Search Functionality Check
List Functionality Check
Show individual item functionality (link to original recipe opens in new tab)
Styling
Foundation Styling for responsive layout Responsive, but the tables aren't great for smaller screens.
List View shows 10 items at a time/pagination Check, but the pagination is there even for 0 results.
The app is styled to create an attractive user interface Nicely attractive.
API Features
The App attributes Edaman Check
The VCR casettes do not contain the API key Check
External Resources
Link to deployed app on Heroku Check
Overall Great work on the Google OAuth! Well done, you hit all the major requirements. Awesomework!

CheezItMan
CheezItMan reviewed Nov 7, 2017
View reviewed changes
test/controllers/recipes_controller_test.rb
end
end

it "will render 404 for a bogus recipe" do
Copy link

@CheezItMan CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also run a test with a search term that gets no responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@murog @CheezItMan